feat: provision to setup opening entries for salary paid till date and tax deducted till date #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh6790
force-pushed
the
opening_entries_for_earnings_and_tax
branch
3 times, most recently
from
29233c9 to
96087e1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #166 +/- ##
===========================================
+ Coverage 70.68% 70.71% +0.02%
===========================================
Files 178 178
Lines 8982 9015 +33
===========================================
+ Hits 6349 6375 +26
- Misses 2633 2640 +7
|
nabinhait
requested changes
Nov 30, 2022
hrms/payroll/doctype/salary_structure_assignment/salary_structure_assignment.py
Outdated
Show resolved
Hide resolved
hrms/payroll/doctype/salary_structure_assignment/salary_structure_assignment.py
Outdated
Show resolved
Hide resolved
saurabh6790
force-pushed
the
opening_entries_for_earnings_and_tax
branch
from
5844bea to
049b23f
Compare
saurabh6790
force-pushed
the
opening_entries_for_earnings_and_tax
branch
from
ccc6095 to
5ad8e26
Compare
nabinhait
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
There is no salary slip record in Frappe HRMS for the period of July to November. Now from November user wants to maintain salary slips in Frappe HRMS. But in Frappe HRMS, there is no provision to set up the salary paid to date and tax deducted it.
Solution
Provision to set up opening balances for Salary paid to date and tax deducted to date.
Warning message
