Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Separation fixes #18

Merged
merged 6 commits into from
Jul 20, 2022
Merged

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Jul 20, 2022

Closes: #17
Closes: #16

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.73%. Comparing base (071568d) to head (db08991).
Report is 2699 commits behind head on develop.

Files with missing lines Patch % Lines
hrms/payroll/doctype/gratuity/gratuity.py 85.00% 3 Missing ⚠️
setup.py 0.00% 3 Missing ⚠️
...t/income_tax_computation/income_tax_computation.py 50.00% 1 Missing ⚠️
hrms/setup.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #18      +/-   ##
===========================================
+ Coverage    71.69%   71.73%   +0.04%     
===========================================
  Files          174      174              
  Lines         8591     8623      +32     
===========================================
+ Hits          6159     6186      +27     
- Misses        2432     2437       +5     
Files with missing lines Coverage Δ
hrms/overrides/employee_payment_entry.py 73.33% <100.00%> (+3.18%) ⬆️
...t/income_tax_computation/income_tax_computation.py 91.59% <50.00%> (-0.36%) ⬇️
hrms/setup.py 0.00% <0.00%> (ø)
hrms/payroll/doctype/gratuity/gratuity.py 87.34% <85.00%> (-0.74%) ⬇️
setup.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@ruchamahabal ruchamahabal merged commit 81161da into frappe:develop Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create Payment entry via 'Create' button Payroll & Income Tax related reports not working
2 participants