fix(UX): validate missing Income Tax Slab in Salary Structure Assignment #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
changed the title
ruchamahabal
added
backport version-14-hotfix
backport version-15-hotfix
and removed
needs-tests
labels
ruchamahabal
changed the title
ruchamahabal
added a commit
that referenced
this pull request
Jun 25, 2024
…ent (backport #1912) (#1915) * fix: validate missing income tax slab in Salary Structure Assignment * test(fix): income tax slab mapping (cherry picked from commit bb8b254) Co-authored-by: Rucha Mahabal <[email protected]>
ruchamahabal
added a commit
that referenced
this pull request
Jun 25, 2024
…ent (backport #1912) (#1914) * fix: validate missing income tax slab in Salary Structure Assignment * test(fix): income tax slab mapping (cherry picked from commit bb8b254) Co-authored-by: Rucha Mahabal <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
# [15.23.0](v15.22.3...v15.23.0) (2024-06-26) ### Bug Fixes * ignore links while adding lending docperms to ess (backport [#1916](#1916)) ([#1919](#1919)) ([198061a](198061a)) * TypeError in Salary Slip Creation Due to Uninitialized Loans Field (backport [#1909](#1909)) ([#1922](#1922)) ([7869b4a](7869b4a)) * **UX:** validate missing Income Tax Slab in Salary Structure Assignment (backport [#1912](#1912)) ([#1915](#1915)) ([04ec743](04ec743)) ### Features * add attachment for each type of proof in income tax proof submission instead of one single attachment (backport [#1893](#1893)) ([#1921](#1921)) ([1a92a66](1a92a66))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the user only learns about missing income tax slabs in salary structure assignments when they run the payroll. By then the assignment is already submitted and changing it becomes difficult.
Validate this in the assignment itself if any tax component is found