fix: Use frm instead of this
#1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
approved these changes
Jul 21, 2024
This was referenced Jul 21, 2024
ruchamahabal
pushed a commit
that referenced
this pull request
Jul 21, 2024
ruchamahabal
pushed a commit
that referenced
this pull request
Jul 21, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 27, 2024
# [15.25.0](v15.24.0...v15.25.0) (2024-07-27) ### Bug Fixes * **FnF:** ignore GL entry links & notify update on payment submission/cancellation ([8bbe23a](8bbe23a)) * skip Bank Entry for withheld salary slips ([ae7deb8](ae7deb8)) * Use `frm` instead of `this` (backport [#1990](#1990)) ([#1995](#1995)) ([5a2dcf2](5a2dcf2)) * validate duplicate salary withholdings ([107362b](107362b)) ### Features * add 'Withheld' status to Salary Slip ([609e71d](609e71d)) * add Salary Withholding doctypes ([0987460](0987460)) * add withholding cycle reference to salary slip & enable no-copy for read-only fields ([f390572](f390572)) * btn in Payroll Entry to Release Withheld Salaries ([6a6e430](6a6e430)) * dashboard connection for Salary Withholding from employee master ([1604939](1604939)) * fetch employees with withheld salaries in payroll entry ([cad5473](cad5473)) * link bank entry in salary withholdings ([387bcd7](387bcd7)) * populate withholding cycles in child table and set To Date ([80e60cd](80e60cd)) * pull withheld salary slips in FnF ([6b40f56](6b40f56)) * set withholding doc ref & status in salary slip ([390fc29](390fc29)) * status field in salary withholding based on withholding status for all cycles ([4a3f912](4a3f912)) * update salary withholding payment status on JV submission/cancellation ([fa5f179](fa5f179)) * update withholding status in payroll employee table ([a8695aa](a8695aa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thisrefers to the window object that does not have a doctype attributeOn v14,
thisseems to not be initialized and results in: