Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gantt chart view in the attendance #2061

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: gantt chart view in the attendance #2061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hrms/hr/doctype/attendance/attendance_calendar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// For license information, please see license.txt
frappe.views.calendar["Attendance"] = {
field_map: {
start: "start",
end: "end",
start: "attendance_date",
end: "attendance_date",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the calendar view?

Since the backend API passes start & end and as the attendance_date and attendance_date is not explicitly passed

hrms/hrms/hr/doctype/attendance/attendance.py

Lines 270 to 271 in 0487ba2

"start": d.attendance_date,
"end": d.attendance_date,

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue has been present for a long time. I use my ERP hosted on Frappe Cloud and tried to update/add fields in the attendance doctype, but had no luck.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the calendar view?

Hi @ruchamahabal,

The issue isn't breaking the calendar view; rather, it's showing a mismatch. Can you suggest what we should do about this?

When we add the attendance_date, the Gantt chart works, but the calendar shows a mismatch. Conversely, when we use start and end, the calendar displays correctly, but the Gantt chart does not work.

id: "name",
title: "title",
allDay: "allDay",
Expand Down
Loading