fix: setup wizard breaks for non-admin user during ERPNext setup on frappehr.com domains #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
added
backport version-14-hotfix
backport version-15-hotfix
and removed
needs-tests
labels
- hrms disables erpnext-specific roles after install. FC now logs the user in as system manager and not as an admin, so erpnext setup breaks due to missing roles - solution: move disabling roles to `setup_wizard_complete` hook
ruchamahabal
force-pushed
the
fix-setup-wizard
branch
from
1bb4044 to
3a8e268
Compare
ruchamahabal
changed the title
ruchamahabal
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
…rappehr.com domains (#2100) - hrms disables erpnext-specific roles after install. FC now logs the user in as system manager and not as an admin, so erpnext setup breaks due to missing roles - solution: move disabling roles to `setup_wizard_complete` hook (cherry picked from commit 9baf711) # Conflicts: # hrms/subscription_utils.py
ruchamahabal
added a commit
that referenced
this pull request
Aug 21, 2024
…rappehr.com domains (backport #2100) (#2102) - hrms disables erpnext-specific roles after install. FC now logs the user in as system manager and not as an admin, so erpnext setup breaks due to missing roles - solution: move disabling roles to `setup_wizard_complete` hook (cherry picked from commit 9baf711) Co-authored-by: Rucha Mahabal <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
# [15.27.0](v15.26.0...v15.27.0) (2024-08-21) ### Bug Fixes * backport german translations from develop ([#2098](#2098)) ([6cf777d](6cf777d)) * **PWA:** Allow login using username (backport [#2090](#2090)) ([#2095](#2095)) ([514b782](514b782)) * setup wizard breaks for non-admin user during ERPNext setup on frappehr.com domains (backport [#2100](#2100)) ([#2102](#2102)) ([3e7bb1f](3e7bb1f)) ### Features * add HR app to apps page ([#2076](#2076)) ([#2096](#2096)) ([f676dd4](f676dd4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
hrmsdisables erpnext-specific roles after install.This used to work fine earlier as FC used to login and run setup wizard as admin. But FC now logs the user in as the system manager and not as an admin, so erpnext setup breaks due to missing roles
Solution: move disabling roles to
setup_wizard_completehook