Fix bugs monthly attendance sheet #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2022 02:49
This bug happens when doesn't exist Attendance records. Fix AttributeError: 'int' object has no attribute 'year'
This bug happens when we try to call the get_holiday_status method with 'holidays' parameter equal None. Bug: TypeError: 'NoneType' object is not iterable
|
@riandrys Please add pr description or link of the issue |
saurabh6790
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: year_list when doesn't exist attendance records
This bug happens when we open the Report Monthly Attendance Sheet and doesn't exist Attendance records.
Fix AttributeError: 'int' object has no attribute 'year'
fix: get_holiday_status when holidays are None
This bug happens when we try to call the get_holiday_status method
with 'holidays' parameter equal None.
'holidays' is None because the company doesn't have a Default Holiday List defined and the employees don't have a Holiday List defined either.
Bug: TypeError: 'NoneType' object is not iterable
