Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter Employee doesn't work correctly in Report Monthly Attendance Sheet #223

Merged

Conversation

riandrys
Copy link
Contributor

Report Monthly Attendance Sheet
Filter Employee doesn't work properly when Summarized View is Checked.

image
image
image

Filter Employee doesn't work properly when Summarized View is Checked.
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #223 (718fd67) into develop (f170be7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
+ Coverage    70.69%   70.74%   +0.04%     
===========================================
  Files          178      178              
  Lines         8982     9013      +31     
===========================================
+ Hits          6350     6376      +26     
- Misses        2632     2637       +5     
Impacted Files Coverage Δ
...nthly_attendance_sheet/monthly_attendance_sheet.py 95.66% <100.00%> (+0.05%) ⬆️
...rms/payroll/doctype/payroll_entry/payroll_entry.py 77.20% <0.00%> (-0.40%) ⬇️
hrms/payroll/doctype/salary_slip/salary_slip.py 87.08% <0.00%> (-0.06%) ⬇️
hrms/hr/doctype/hr_settings/hr_settings.py 71.42% <0.00%> (ø)
...yroll/doctype/salary_structure/salary_structure.py 80.70% <0.00%> (ø)
...tructure_assignment/salary_structure_assignment.py 82.55% <0.00%> (+0.30%) ⬆️
hrms/hr/doctype/shift_type/shift_type.py 89.41% <0.00%> (+2.35%) ⬆️

Report Monthly Attendance Sheet
Add test with Employee filter and Summarized View
Modify test test_attendance_with_employee_filter
@saurabh6790 saurabh6790 merged commit fb6d284 into frappe:develop Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants