build: fix v15 yarn lock #2344
Merged
build: fix v15 yarn lock #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
approved these changes
Oct 28, 2024
|
Unrelated flaky test failure |
|
@ruchamahabal There's now a shared action with: https://github.com/frappe/frappe/blob/61a107b6aff3e3bbe2f3999689acab9605e26570/.github/workflows/tests-ui-base.yml#L90-L93 Not tested yet, but I'm trying to dogfood via frappe/frappe#28300 — if that works out, then I'll propose to adopt for ERPNext, and after that it could be considered for HRMS, as well. |
ruchamahabal
added a commit
that referenced
this pull request
Oct 31, 2024
This reverts commit 0927f77.
|
Reverting this PR to backport #2370 |
|
🎉 This PR is included in version 15.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would there be a way to assert that releases are fully locked?
Outdated lock files break reproducible builds.
closes: #2342 and unblocks blaggacao/frappix#16