fix(Payroll Bank Entry): deduct loan repayments from employee-wise accounting entries #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
force-pushed
the
fix-loan-bank-entry
branch
from
11dbc4d to
e5af27c
Compare
ruchamahabal
added a commit
that referenced
this pull request
Nov 8, 2024
…2403 fix(Payroll Bank Entry): deduct loan repayments from employee-wise accounting entries (backport #2403)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In continuation to #2347, #2283 & #2324
#2347 deducts total loan repayments from salary payable but doesn't handle loan repayment deduction when Process Payroll Accounting Entry based on Employee is enabled in Payroll Settings.
This leads to difference in total debit and credit amount in Bank Entry
Before
Net Pay = 50000 - 2000 (loan repayment)
Bank Entry failing
This is the bank entry its trying to create
After