Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Union to validate multiple types in type indication #241

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

saurabh6790
Copy link
Member

@saurabh6790 saurabh6790 commented Dec 20, 2022

use Union to validate multiple types in type indication

@codecov-commenter
Copy link

Codecov Report

Merging #241 (cad90fc) into develop (6362fd8) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #241   +/-   ##
========================================
  Coverage    70.77%   70.77%           
========================================
  Files          178      178           
  Lines         9039     9039           
========================================
  Hits          6397     6397           
  Misses        2642     2642           
Impacted Files Coverage Δ
.../hr/doctype/leave_application/leave_application.py 79.20% <100.00%> (ø)

@ruchamahabal ruchamahabal merged commit 18f76f3 into frappe:develop Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants