fix: Editable Letter Head field in Salary Structure Doctype #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doctype, to make it editable, set the company defualt letter head using form script instead
asmitahase
changed the title
| @@ -48,7 +48,6 @@ | |||
| "search_index": 1 | |||
| }, | |||
| { | |||
| "fetch_from": "company.default_letter_head", | |||
There was a problem hiding this comment.
Instead, you can let this be and just enable "fetch if empty". That will let you overwrite the letter head
Also let's enable "Allow on Submit" for this field so that people don't have to cancel the entire structure to edit this.
There was a problem hiding this comment.
Smart, shoulda thought of that, done
… if empty" to make the field editable, intead of using form script to set the value
| "modified_by": "Administrator", | ||
| "module": "Payroll", | ||
| "name": "Salary Structure", | ||
| "naming_rule": "Set by user", | ||
| "owner": "Administrator", | ||
| "permissions": [ |
There was a problem hiding this comment.
Default perms got removed accidentally IG
There was a problem hiding this comment.
they're removed while saving the updated doctype settings, couldn't figure out why, added them back
…n't figure out why, added them back
ruchamahabal
approved these changes
Nov 22, 2024
ruchamahabal
pushed a commit
that referenced
this pull request
Nov 25, 2024
…2436) (#2443) Co-authored-by: asmitahase <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
## [15.35.3](v15.35.2...v15.35.3) (2024-11-26) ### Bug Fixes * Editable Letter Head field in Salary Structure Doctype (backport [#2436](#2436)) ([#2443](#2443)) ([f948a36](f948a36)) * filters on vehicle expenses report (backport [#2440](#2440)) ([#2447](#2447)) ([4e4425c](4e4425c)) * ignore linked ledger entry record on employee advance cancellation (backport [#2432](#2432)) ([#2433](#2433)) ([e1d9514](e1d9514)) * redundant fetching of Interviewers in Interview ([#2441](#2441)) ([62cd631](62cd631)) * **Salary Structure Assignment:** validate cost center company on server-side (backport [#2445](#2445)) ([#2450](#2450)) ([7f5e969](7f5e969))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Salary Structure doctype has "fetch from" setting to fetch company default letterhead so no other letter head can be set while creating salary structure. The same field value is mapped to salary slip, so for companies where the salary letter head is different from company letter head, the letter head field has to be changed manually while creating salary slip.
Fix
Removed "fetch from company default letter head" setting from Salary Structure and used form script to set the field value instead.
Before
After
no-tests