fix: filters on vehicle expenses report (backport #2440) #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit f382a94)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
## [14.35.2](v14.35.1...v14.35.2) (2024-11-26) ### Bug Fixes * filters on vehicle expenses report (backport [#2440](#2440)) ([#2446](#2446)) ([6d35f11](6d35f11)) * ignore linked ledger entry record on employee advance cancellation (backport [#2432](#2432)) ([#2434](#2434)) ([8058d74](8058d74)) * **Salary Structure Assignment:** validate cost center company on server-side (backport [#2445](#2445)) ([#2449](#2449)) ([51831cb](51831cb))
|
🎉 This PR is included in version 14.35.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Filters on Vehicle expense report are conditional based on "Fiscal Year" or "Date Range" but they are all set to be
mandatory. So when "Fiscal Year" is selected the report shows up but the console throws error for date filters not being set. When "Date Range" is selected the missing filter on Fiscal Year prevents the report from loading and "Please set filter" shows up.
The problem is gone even if the order of the filters in the report script is exchanged. Will dig deeper into this, for now
Fix:
Made the requirement of the filters conditional based on "Fiscal Year" or "Date Range"
Before
After
The issue was in frontend script, no-tests-required
This is an automatic backport of pull request #2440 done by Mergify.