fix: set correct work experience during gratuity calculation #2460
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
reviewed
Dec 6, 2024
| @@ -159,7 +159,7 @@ def get_work_experience(self) -> float: | |||
| if rule.method == "Round off Work Experience": | |||
| work_experience = round(work_experience) | |||
| else: | |||
| work_experience = floor(work_experience) | |||
| work_experience = flt(work_experience, precision=1) | |||
There was a problem hiding this comment.
Suggested change
| work_experience = flt(work_experience, precision=1) | |
| work_experience = flt(work_experience, self.precision("current_work_experience")) |
Instead of using a hardcoded precision let's set field level precision. You can set 1 as the default precision in core for this field. So when people want to have more precision, they can just customize field level precision and this calculation will get adjusted
ruchamahabal
previously approved these changes
Dec 11, 2024
|
Why didn't linter catch this da17577? 🤔 |
This was referenced Dec 12, 2024
|
@Mergifyio backport version-14-hotfix version-15-hotfix |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix work experience calculation for gratuity rules using the Take Exact Completed Years method. Previously, the experience was rounded to a whole number instead of using the exact decimal value (eg. 1.4 years was incorrectly treated as 1 year).
Gratuity Rule:
Before:
After:
