Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip sending interview reschedule email if interview reminder is disabled in HR Settings #2507

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

niyazrazak
Copy link
Contributor

@niyazrazak niyazrazak commented Dec 15, 2024

no-docs

Comment on lines +100 to +107
reminder_settings = frappe.db.get_value(
"HR Settings",
"HR Settings",
["send_interview_reminder"],
as_dict=True,
)

if not cint(reminder_settings.send_interview_reminder):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reminder_settings = frappe.db.get_value(
"HR Settings",
"HR Settings",
["send_interview_reminder"],
as_dict=True,
)
if not cint(reminder_settings.send_interview_reminder):
if not cint(frappe.db.get_single_value("HR Settings", "send_interview_reminder")):
return

Simplify this
Also move the msgprint before this line, so that we don't have to write it again on line number 133

@ruchamahabal ruchamahabal changed the title chore: interview reschedule email alert based on hr setting fix: skip sending interview reschedule email if interview reminder is disabled in HR Settings Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants