-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display tax break up on salary slip #267
Merged
saurabh6790
merged 20 commits into
frappe:develop
from
saurabh6790:display-tax-calculation-on-salary-slip
Feb 20, 2023
Merged
feat: display tax break up on salary slip #267
saurabh6790
merged 20 commits into
frappe:develop
from
saurabh6790:display-tax-calculation-on-salary-slip
Feb 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh6790
force-pushed
the
display-tax-calculation-on-salary-slip
branch
4 times, most recently
from
January 27, 2023 10:56
12a51d7
to
bd421ba
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #267 +/- ##
===========================================
+ Coverage 71.00% 71.33% +0.32%
===========================================
Files 181 181
Lines 9195 9321 +126
===========================================
+ Hits 6529 6649 +120
- Misses 2666 2672 +6
|
saurabh6790
force-pushed
the
display-tax-calculation-on-salary-slip
branch
5 times, most recently
from
February 15, 2023 06:05
4d3bb88
to
c1dcc3b
Compare
@saurabh6790 Income Tax Breakup fields can be organised like below: |
ruchamahabal
requested changes
Feb 16, 2023
saurabh6790
force-pushed
the
display-tax-calculation-on-salary-slip
branch
from
February 16, 2023 11:34
65707e6
to
861fc85
Compare
@ruchamahabal fixed! |
@nabinhait Reorganised as per the suggestion |
@saurabh6790 can you address the unresolved conversations about splitting functions? |
saurabh6790
force-pushed
the
display-tax-calculation-on-salary-slip
branch
2 times, most recently
from
February 17, 2023 06:35
e102dd0
to
de219e8
Compare
@ruchamahabal Added test case. PR is ready to merge |
…exemption_declaration, standard_tax_exemption_amount and annual_taxable_amount
saurabh6790
force-pushed
the
display-tax-calculation-on-salary-slip
branch
from
February 17, 2023 10:13
40aa049
to
b1ca898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provision to display income tax deduction on salary slip.
Salary Structure Assignment
Income tax breakup on Salary Slip
Income Tax Deducted Till Date + Future Income Tax Deductions
9,583.33+1,05,416.67 = 1,15,000
Total payable tax as per Income tax computation
Calculations / Formula
Re-write queries
Re-write queries in frappe ORM format for Salary Slip DocType