Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect system precision in leave application dashboard and reports #300

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Feb 11, 2023

Leave Application dashboard not respecting system precision:

Before:

image

image

After:

image

image

Leave Balance reports not respecting system precision:

Before:
image

After:
image

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #300 (0191844) into develop (4024655) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #300      +/-   ##
===========================================
- Coverage    70.91%   70.85%   -0.06%     
===========================================
  Files          181      181              
  Lines         9158     9161       +3     
===========================================
- Hits          6494     6491       -3     
- Misses        2664     2670       +6     
Impacted Files Coverage Δ
.../hr/doctype/leave_application/leave_application.py 79.24% <100.00%> (+0.04%) ⬆️
...t/employee_leave_balance/employee_leave_balance.py 94.59% <100.00%> (+0.09%) ⬆️
hrms/hr/doctype/shift_type/shift_type.py 87.50% <0.00%> (-4.55%) ⬇️
...ms/hr/doctype/shift_assignment/shift_assignment.py 90.77% <0.00%> (-0.49%) ⬇️
hrms/payroll/doctype/salary_slip/salary_slip.py 87.42% <0.00%> (-0.12%) ⬇️

@ruchamahabal ruchamahabal changed the title fix: respect system precision in leave application dashboard fix: respect system precision in leave application dashboard and reports Feb 11, 2023
@ruchamahabal ruchamahabal merged commit 6b87bde into frappe:develop Feb 11, 2023
@ruchamahabal ruchamahabal deleted the precision branch February 11, 2023 15:48
ruchamahabal added a commit that referenced this pull request Feb 13, 2023
@ruchamahabal ruchamahabal added the backport version-13-hotfix Needs manual backporting to frappe/erpnext label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-13-hotfix Needs manual backporting to frappe/erpnext backport version-14-hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants