fix: incorrect tax calculation in case of reduced payment days #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
After frappe/erpnext#31521 components dependent on other components (based on payment days) started getting updated values while setting up "default amount" itself.
This leads to incorrect TDS calculations for employees with lesser payment days in the current month. TDS considers the default amount (without payment days) while calculating the taxable amount.
Structure:
Salary Slip for the employee with DOJ 4/7/22 = 28/31 payment days:
Fix:
Keep a track of default amounts for components to update default amounts for dependent components.