fix: round pro-rated leaves

[rtdany10]

Employee Date of Joining: 25-01-2023

Leave Policy:

Leave Policy Assignment:

---

Leave Allocation(Earned Leave):

Before:

After:
(based on leave type rounding)

[codecov-commenter]

Codecov Report

Merging #324 (24989f4) into develop (f5399eb) will increase coverage by 0.06%.
The diff coverage is 78.57%.

❗ Current head 24989f4 differs from pull request most recent head d7df612. Consider uploading reports for the commit d7df612 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #324      +/-   ##
===========================================
+ Coverage    70.91%   70.97%   +0.06%     
===========================================
  Files          181      181              
  Lines         9200     9196       -4     
===========================================
+ Hits          6524     6527       +3     
+ Misses        2676     2669       -7     

Impacted Files	Coverage Δ
hrms/hr/utils.py	76.25% <66.66%> (+0.22%)	⬆️
...leave_policy_assignment/leave_policy_assignment.py	91.83% <100.00%> (+0.22%)	⬆️
hrms/hr/doctype/appraisal/appraisal.py	0.00% <0.00%> (ø)
hrms/payroll/doctype/salary_slip/salary_slip.py	87.24% <0.00%> (+0.10%)	⬆️
...oll/doctype/additional_salary/additional_salary.py	70.65% <0.00%> (+0.75%)	⬆️
...s/payroll/doctype/payroll_period/payroll_period.py	86.27% <0.00%> (+1.08%)	⬆️
hrms/hr/doctype/shift_request/shift_request.py	94.36% <0.00%> (+1.12%)	⬆️

[ruchamahabal]

why did the CI job not run 🤔

[rtdany10]

why did the CI job not run thinking

The force push is the culprit behind that. Probably cause of same commit name?
The test was running when I force pushed and it seem to have vanished somehow.

[ruchamahabal]

Probably cause of same commit name?

Commit hash is always different so shouldn't cause an issue. Will check the yaml file 🤔

[ruchamahabal]

@rtdany10 refactored the code a bit:

• get_monthly_earned_leave will take care of pro-rated calculation + rounding instead of leaving this responsibility to every place where this function gets called: https://github.com/frappe/hrms/pull/324/files#diff-791e2445f8ab6f0742f4751a34adc02b37d14265bf16fdd78a96f3c04e9fb520R363-R386
• Handled case for no rounding field set: https://github.com/frappe/hrms/pull/324/files#diff-791e2445f8ab6f0742f4751a34adc02b37d14265bf16fdd78a96f3c04e9fb520R390-R391
• Refactored get_leaves_for_passed_months with better functions: https://github.com/frappe/hrms/pull/324/files#diff-b69585b30cba136869b6173286888ad99c57993c7a40b7295ffe350fe90d6baaR163-R221
• Reduced friction to get pro-rated leaves for other leave types: https://github.com/frappe/hrms/pull/324/files#diff-b69585b30cba136869b6173286888ad99c57993c7a40b7295ffe350fe90d6baaR151-R159