Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UX): Add option to disable consolidating leave types in balance reports #328

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

ruchamahabal
Copy link
Member

Problem:

The Leave Balance report consolidates data based on leave types. If you are using inline filters in the datatable, you will lose out on the Leave Type reference for each row. Eg: Applying a filter on an added column (custom) shift type.

Kapture 2023-02-16 at 14 15 31

Solution

Add an option "Consolidate Leave Type" to disable the consolidated view. Users might also want to export the data with leave-type references for each row. In this case, they can disable this checkbox and export

consolidate-disabled

consolidate-enabled

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #328 (2102a3a) into develop (3960cb2) will increase coverage by 0.03%.
The diff coverage is 88.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #328      +/-   ##
===========================================
+ Coverage    70.97%   71.01%   +0.03%     
===========================================
  Files          181      181              
  Lines         9189     9198       +9     
===========================================
+ Hits          6522     6532      +10     
+ Misses        2667     2666       -1     
Impacted Files Coverage Δ
...t/employee_leave_balance/employee_leave_balance.py 94.73% <88.23%> (+0.14%) ⬆️
hrms/hr/utils.py 76.10% <0.00%> (+0.07%) ⬆️
...leave_policy_assignment/leave_policy_assignment.py 92.56% <0.00%> (+0.95%) ⬆️

@ruchamahabal ruchamahabal marked this pull request as draft February 16, 2023 12:34
@ruchamahabal ruchamahabal force-pushed the consolidate-balance-entries branch from 69f6307 to 2102a3a Compare February 17, 2023 09:56
@ruchamahabal ruchamahabal marked this pull request as ready for review February 17, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants