Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider relieving date while calculating lwp #372

Conversation

saurabh6790
Copy link
Member

@saurabh6790 saurabh6790 commented Mar 8, 2023

Scenario :

The employee has approved leave application of type LWP for three days from 22nd to 24th. But the employee left the organisation before that say on 15th of the month.

  • Future dated approved Leave Application

Screenshot 2023-03-08 at 7 09 54 PM

  • Relieving date for employee

Screenshot 2023-03-08 at 5 26 31 PM

Issue

Though employee left before, the system still consider its future dated leave application while calculating salary. Due to this, instead of getting payment for 11 days, the employee receiving payment for only 8 days (11 - 3)

Payment days calculation before fix

Screenshot 2023-03-08 at 7 09 35 PM

Resolution

Calculate LWP based on relieving date (if applicable)

Payment days calculation after fix

Screenshot 2023-03-08 at 5 26 22 PM

@saurabh6790 saurabh6790 marked this pull request as ready for review March 8, 2023 09:53
@ruchamahabal ruchamahabal changed the title Consider relieving date while calculating lwp fix: Consider relieving date while calculating lwp Mar 8, 2023
@ruchamahabal ruchamahabal self-assigned this Mar 9, 2023
@ruchamahabal ruchamahabal merged commit 5fea591 into frappe:develop Mar 9, 2023
ruchamahabal added a commit that referenced this pull request Mar 9, 2023
fix: Consider relieving date while calculating lwp (backport #372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants