fix: Check employee status for validating salary slip with relieving date lesser than start date #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check status before throw
ruchamahabal
reviewed
Mar 8, 2023
ruchamahabal
requested changes
Mar 8, 2023
ruchamahabal
changed the title
Co-authored-by: Rucha Mahabal <[email protected]>
Co-authored-by: Rucha Mahabal <[email protected]>
ruchamahabal
approved these changes
Mar 9, 2023
|
CI failed while uploading coverage data. Tests are passing. Merging |
mergify bot
pushed a commit
that referenced
this pull request
Mar 9, 2023
…date lesser than start date (#374) Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 3229698)
ruchamahabal
added a commit
that referenced
this pull request
Mar 9, 2023
…date lesser than start date (backport #374) (#378) Co-authored-by: Rucha Mahabal <[email protected]> Co-authored-by: Muhammad Nouman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether employee status is set as "Left" before throwing error