fix: don't allow manual updates for earned leave allocation after submission #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ruchamahabal
added a commit
that referenced
this pull request
Mar 20, 2023
…mission (backport #399) (#400) Co-authored-by: Rucha Mahabal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Earned Leaves are auto-allocated via scheduler based on the annual allocation set in policy assignment.
Manually updating New Leaves Allocated field makes no sense here, since leaves are automatically computed and allocated based on set frequency.
This can mess up the balance and calculation. Also, this validation is essential to overcome other problems like #397
Solution
Make the New Leaves Allocated field read-only if:
Validate the same case on the server-side in
on_update_after_submit