fix: shift request cancellation failing #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
force-pushed
the
shift-req-cancellation
branch
from
a4ed031 to
9265605
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #478 +/- ##
========================================
Coverage 72.84% 72.84%
========================================
Files 190 190
Lines 9805 9805
========================================
Hits 7142 7142
Misses 2663 2663
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit b3d3272)
ruchamahabal
added a commit
that referenced
this pull request
Apr 28, 2023
Co-authored-by: Rucha Mahabal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Shift Request cancellation failed because the framework code for cancelling linked documents first cancels the shift assignment. Then tries to cancel the shift request, which is now trying to cancel a cancelled shift assignment
on_cancelhookFix: Attempt cancelling only submitted assignments. Cannot remove
on_cancelhandler because the framework cancellation is only triggered from client-side.