Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set Expense Claim Payable Account in Expense Claim #51

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

zeta17
Copy link
Contributor

@zeta17 zeta17 commented Sep 6, 2022

When making an Expense Claim from Employee Advance, field Payable Account is still taken from the Company - Default Payable Account, while if you make a new Expense Claim field Payable Account is filled from Company - Default Expense Claim Payable Account.

When making an Expense Claim from Employee Advance, field Payable Account is still taken from the Company - Default Payable Account, while if you make a new Expense Claim field Payable Account is filled from Company - Default Expense Claim Payable Account.
@zeta17 zeta17 requested a review from ruchamahabal as a code owner September 6, 2022 03:33
@zeta17 zeta17 changed the title Set field Payamble Account in Expese Claim Set field Payamble Account in Expense Claim Sep 6, 2022
@ruchamahabal ruchamahabal changed the title Set field Payamble Account in Expense Claim fix: set Expense Claim Payable Account in Expense Claim Sep 7, 2022
@ruchamahabal
Copy link
Member

@zeta17 A note for future contributions: Commit messages must follow the conventional commit specifications:
conventionalcommits.org/en/v1.0.0-beta.2

@codecov-commenter
Copy link

Codecov Report

Merging #51 (d739b1e) into develop (1e7a11f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #51      +/-   ##
===========================================
- Coverage    71.28%   71.23%   -0.05%     
===========================================
  Files          176      176              
  Lines         8761     8761              
===========================================
- Hits          6245     6241       -4     
- Misses        2516     2520       +4     
Impacted Files Coverage Δ
hrms/hr/doctype/expense_claim/expense_claim.py 84.07% <0.00%> (ø)
hrms/hr/doctype/shift_type/shift_type.py 86.41% <0.00%> (-2.47%) ⬇️
...ms/hr/doctype/shift_assignment/shift_assignment.py 90.77% <0.00%> (-0.49%) ⬇️
hrms/payroll/doctype/salary_slip/salary_slip.py 87.06% <0.00%> (-0.13%) ⬇️

@ruchamahabal ruchamahabal merged commit 23ab4ca into frappe:develop Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants