Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change Department fieldtype to Link in Leave Balance Report #59

Merged
merged 1 commit into from
Sep 19, 2022
Merged

fix: Change Department fieldtype to Link in Leave Balance Report #59

merged 1 commit into from
Sep 19, 2022

Conversation

Solufyin
Copy link
Contributor

Version:

ERPNext: v14.1.2
Frappe Framework: v14.7.0
Payments: 0.0.1
HRMS: 0.0.1


Reference PR: frappe/erpnext#32252


Before:

  • When add column from the report then does not show link fields like employee and department.

After:

  • After set the link field option, when add columns from the report then link fields will appear.

_("Employee") + ":Link.Employee:150", ---> _("Employee") + ":Link/Employee:150",
_("Department") + "::150", ---> _("Department") + ":Link/Department:150",

Thank You!

@ruchamahabal ruchamahabal changed the title fix: Set dialog link field fix: Change Department fieldtype to Link in Leave Balance Report Sep 19, 2022
@ruchamahabal ruchamahabal merged commit 52b7b5c into frappe:develop Sep 19, 2022
@ArunaDevraj
Copy link

After set the link field option, when refresh the site it shows as like: IndexError: list index out of range

@Solufyin Solufyin deleted the elbs-v14 branch December 22, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants