-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(UX): Tabbed view for Payroll module doctypes #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, maybe we can skip the tabbed view for smaller forms that fit within a viewport to save clicks? Example:
- Employee Benefit Application & Claim
- Income Tax Slab
- Employee Incentive
- Retention Bonus, etc
f703326
to
1c20828
Compare
@ruchamahabal Pushed fixes! |
1c20828
to
089baba
Compare
089baba
to
26012fd
Compare
"depends_on": "eval:doc.docstatus==0", | ||
"fieldname": "get_employees", | ||
"fieldtype": "Button", | ||
"label": "Get Employees" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this button is associated with the table but IMO, moving this button inside the form has made it more confusing. Primary action was more intuitive. Maybe we should keep the employee table on page 1 itself, and revert back to the primary action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added scroll_to_field
instead. @saurabh6790 is this okay?
scroll.mp4
- scroll to employees table on getting employees
Additional Salary
Employee Benefit Application
Employee Benefit Claim
Employee Incentive
Employee Other Income
Employee Tax Exemption Declaration
Employee Tax Exemption Proof Submission
Gratuity
Gratuity Rule
Income Tax Slab
Payroll Entry
Retention Bonus
Salary Component
Salary Slip
Salary Structure
Salary Structure Assignment