Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(UX): Tabbed view for Payroll module doctypes #88

Merged
merged 8 commits into from
Jan 9, 2023

Conversation

saurabh6790
Copy link
Member

@saurabh6790 saurabh6790 commented Oct 20, 2022

Additional Salary

Screenshot 2022-11-08 at 4 11 20 PM

Employee Benefit Application

Screenshot 2022-11-08 at 4 17 45 PM

Employee Benefit Claim

Screenshot 2022-11-08 at 4 41 24 PM

Employee Incentive

Screenshot 2022-11-08 at 4 49 56 PM

Employee Other Income

Screenshot 2022-11-08 at 4 51 18 PM

Employee Tax Exemption Declaration

Screenshot 2022-11-08 at 5 04 41 PM

Employee Tax Exemption Proof Submission

Screenshot 2022-11-08 at 5 07 01 PM

Gratuity

Screenshot 2022-11-09 at 3 47 43 PM

Gratuity Rule

Screenshot 2022-11-09 at 3 53 47 PM

Income Tax Slab

Screenshot 2022-11-09 at 4 09 37 PM

Payroll Entry

Screenshot 2022-11-09 at 4 32 39 PM

Retention Bonus

Screenshot 2022-11-09 at 4 33 21 PM

Salary Component

Screenshot 2022-11-09 at 4 45 40 PM

Screenshot 2022-11-09 at 4 45 57 PM

Salary Slip

Screenshot 2022-11-09 at 4 52 46 PM

Salary Structure

Screenshot 2022-10-20 at 5 02 01 PM

Salary Structure Assignment

Screenshot 2022-11-09 at 4 58 37 PM

Copy link
Member

@ruchamahabal ruchamahabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop "Details" from the tabs.

I had also titled them in a similar way earlier:

image

But I changed it to shorter titles for a cleaner view:

image

Copy link
Member

@ruchamahabal ruchamahabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, maybe we can skip the tabbed view for smaller forms that fit within a viewport to save clicks? Example:

  • Employee Benefit Application & Claim
  • Income Tax Slab
  • Employee Incentive
  • Retention Bonus, etc

@saurabh6790
Copy link
Member Author

@ruchamahabal Pushed fixes!

@ruchamahabal ruchamahabal changed the title fix: ux for payroll module refactor(UX): Tabbed view for Payroll module doctypes Jan 5, 2023
Comment on lines 303 to 307
"depends_on": "eval:doc.docstatus==0",
"fieldname": "get_employees",
"fieldtype": "Button",
"label": "Get Employees"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this button is associated with the table but IMO, moving this button inside the form has made it more confusing. Primary action was more intuitive. Maybe we should keep the employee table on page 1 itself, and revert back to the primary action.

Copy link
Member

@ruchamahabal ruchamahabal Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added scroll_to_field instead. @saurabh6790 is this okay?

scroll.mp4

@ruchamahabal ruchamahabal merged commit bfaa30f into frappe:develop Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants