This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 359
add serverside testing #139
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3208c65
test app class
timmyichen a97a84a
jest config
timmyichen 96d9b09
add exampleRouter test
timmyichen 20cc5fc
move package.json jest config to jest.config.js
timmyichen 054e4e3
rebase
timmyichen 9c2bc66
fix client tests
timmyichen 6abb0a4
run docker in ci
timmyichen df18051
no cli
timmyichen 3998501
try -T flag
timmyichen 569c35f
oops i put it in the wrong place
timmyichen ff99a80
private
timmyichen 732b8c6
remove sample env, update docs
timmyichen 83bd0d9
rebase
timmyichen cb0fb19
recreate packagelock
timmyichen e203942
fix import
timmyichen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,10 @@ services: | |
- DB_PASSWORD=password | ||
- DB_NAME=chapter | ||
- DB_URL=db | ||
- [email protected] | ||
- EMAIL_USERNAME=emailUsernamePlaceholder | ||
- EMAIL_PASSWORD=emailPasswordPlaceholder | ||
- EMAIL_SERVICE=emailServicePlaceholder | ||
volumes: | ||
- .:/usr/chapter | ||
ports: | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
module.exports = { | ||
preset: 'ts-jest', | ||
testEnvironment: 'node', | ||
roots: ['<rootDir>'], | ||
transform: { | ||
'^.+\\.tsx?$': 'babel-jest', | ||
}, | ||
moduleDirectories: ['node_modules', 'server'], | ||
moduleNameMapper: { | ||
'^server/(.*)': '<rootDir>/server/$1', | ||
}, | ||
globals: { | ||
'ts-jest': { | ||
diagnostics: false, | ||
}, | ||
}, | ||
watchPathIgnorePatterns: ['/node_modules'], | ||
moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx'], | ||
testMatch: ['/**/*.test.(ts|js|tsx|jsx)'], | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Env
variables will grow in the future, shouldn't we maintain separate.env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the most part, there's no functional difference between having a long list of env variables in the docker-compose file and a long list of env variables in
.env
. With a separate .env file, you are requiring people to copy/rename a file before running it whereas this will be set up when you rundocker-compose up
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of simplicity I think that for now we should stick with env vars in docker-compose, but maybe later when we have a lot of them we could extract them.