This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 28
Relax rules for commit messages #54
Labels
Comments
I'm all for this. I do see merit in having consistency in regards to a full stop, the only thing I care about is consistency. Happy to keep enforcing full stops? |
Are we enforcing full stops? Haven't tripped that rule yet |
I'm guilty of having tripped that plenty of times, an old habit. Appears commitlint/config-conventional, which we extend, enforces subject-full-stop. |
So, are we saying
?? |
Let's keep the default of "full stop - no". |
Merged
May I work on this? My assumption to config the |
All yours @user512 ! |
user512
added a commit
to user512/open-api
that referenced
this issue
May 13, 2018
Allow commit message to be consistent with code changed ISSUES CLOSED: freeCodeCamp#54
user512
added a commit
to user512/open-api
that referenced
this issue
May 13, 2018
Allow commit message to be consistent with code changed ISSUES CLOSED: freeCodeCamp#54
user512
added a commit
to user512/open-api
that referenced
this issue
May 13, 2018
Allow commit message to be consistent with code changed ISSUES CLOSED: freeCodeCamp#54
user512
added a commit
to user512/open-api
that referenced
this issue
May 13, 2018
Allow commit message to be consistent with code changed ISSUES CLOSED: freeCodeCamp#54
user512
added a commit
to user512/open-api
that referenced
this issue
May 13, 2018
Allow commit message to be consistent with code changed ISSUES CLOSED: freeCodeCamp#54
@Bouncey I tested the PR with your example commit message and returns no error/ warning. |
ojongerius
pushed a commit
that referenced
this issue
May 13, 2018
Allow commit message to be consistent with code changed ISSUES CLOSED: #54
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I like the rules for commit messages, but please can we relax them.
My proposal:
$1($2): $3
$1
: One offeat fix chore docs tests
$2
: Any single word, any case$3
: Any string, any caseExample:
feat(types): Expand User type and apply 'on-the-fly' migrations
Reasoning:
I like to keep my commit messages consistent with the code is touches. If I fix a bug in
someBuggyFunction
, I want to reference it in my commit message. Or if I am working with types, I want to use StartCase in the commit message to reference the type I have worked on, which uses StartCase in the code base.The text was updated successfully, but these errors were encountered: