fix: handle mismatch between a dbgsym package's extension and buildinfo record
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…info record Match on both Ubuntu-style ".ddeb" and Debian-style ".deb" extensions for "dbgsym" packages, but always use the latter for lookup.
cfm
force-pushed
the
504-ubuntu-dbgsym
branch
from
7b882c6 to
5080a07
Compare
legoktm
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Awesome, thanks!
user@dev ~/g/f/securedrop-apt-test ((d209e548))> ../securedrop-builder/scripts/check-buildinfo --against HEAD~1 ../build-logs/
OK: got expected checksum 2d3d6e6e5d551dbe9aa59df2179b41a65a180d986bd5919df0a329a56c238c50 for securedrop-app-code-dbgsym_2.11.0~rc1+focal_amd64.deb
OK: got expected checksum 47ec148c14b6961a1d1116e9dfe9c68465fcdf7ab1ac95dd8db8e1a09302843f for securedrop-app-code_2.11.0~rc1+focal_amd64.deb
OK: got expected checksum af4ef1de1ed3d3572077cd4a7adf9f82e5cb878676714dba15f7e0517f5bc9e2 for securedrop-config-dbgsym_2.11.0~rc1+focal_amd64.deb
OK: got expected checksum ffc62dff1f312065b22ee0ff210de0e392ce00524c63a8c2576fbf9683177f1d for securedrop-config_2.11.0~rc1+focal_amd64.deb
OK: got expected checksum 47ca54328fa8914ef99fbd0530c1be401e4b432bac00c7d8d944815616b880c4 for securedrop-keyring_0.2.2+2.11.0~rc1+focal_all.deb
OK: got expected checksum cd2815ef3d7061870d07348e1f90e7b5a77546c0a9b2694dfdcb01daa488cb88 for securedrop-ossec-agent_3.6.0+2.11.0~rc1+focal_all.deb
OK: got expected checksum 1bd5e120fce9be39060cc751375ba8a3211d57a211f4a355709f065913eaa580 for securedrop-ossec-server_3.6.0+2.11.0~rc1+focal_all.deb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504 by matching on both Ubuntu-style
.ddeband Debian-style.debextensions fordbgsympackages, but always use the latter for lookup.Incidentally adds an
--against $REFargument and formats with ruff.Testing
Something like: