refactor(authenticate): let _send_json_request() catch JSONDecodeErrors

Per @legoktm in <#1718 (comment)>.
freedomofpress · Jan 23, 2024 · 984f19d · 984f19d
1 parent 1188421
commit 984f19d
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/client/securedrop_client/sdk/__init__.py b/client/securedrop_client/sdk/__init__.py
@@ -245,12 +245,9 @@ def authenticate(self, totp: Optional[str] = None) -> bool:
         path_query = "api/v1/token"
         body = json.dumps(user_data)
 
-        try:
-            response = self._send_json_request(
-                method, path_query, body=body, timeout=self.default_request_timeout
-            )
-        except json.decoder.JSONDecodeError:
-            raise BaseError("Error in parsing JSON")
+        response = self._send_json_request(
+            method, path_query, body=body, timeout=self.default_request_timeout
+        )
 
         if "expiration" not in response.data:
             raise AuthError("Authentication error")