-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate/deprecate update_version.sh
scripts and adjust VERSION
#1815
Comments
The plan is that there is one version going forwards, that applies to all the components. So we don't need individual update scripts anymore, that can be consolidated. Now, there are a few places where the version is being used in a user facing way:
Presumably the export case isn't as important and just for internal debugging but I think it should be reasonable to keep. I think there are two ways we can handle this:
I think no. 2 is more "pure" as a solution but it's also more magical and it doesn't work properly in dev. No. 1 is also what we've basically done so far so I'm inclined to implement it for now. PR incoming shortly. |
There is now a single `update_version.sh` script that updates the `__version__` variables in the client and export components and increments the debian/changelog file. The proxy version is hardcoded since it's going away as part of proxy v2 (also the usage in the response object was dubious to begin with). Fixes #1815.
There is now a single `update_version.sh` script that updates the `__version__` variables in the client and export components and increments the debian/changelog file. The proxy version is hardcoded since it's going away as part of proxy v2 (also the usage in the response object was dubious to begin with). Fixes #1815.
Description
Post monorepo / debianization refactor: The individual components still have
update_version.sh
, and I wonder if we can DRY that up a little, or deprecate it. Also, I noticed that a component's idea of its version is wrong (theVERSION
file is not updated when webuild-debs.sh
) but maybe this is WIP.Steps to Reproduce
(first issue) Visual observation of files
(second issue)
build-debs.sh
and observe 0.9.0 debs being built. then inspect VERSION in a component and notice a different number (eg 0.3.0 for securedrop-export).Expected Behavior
Actual Behavior
Please provide screenshots where appropriate.
Comments
Suggestions to fix, any other relevant information.
The text was updated successfully, but these errors were encountered: