Enable "merge_group" events for GitHub's merge queue #1857
Conversation
|
This is ready to go whenever, but I'm marking this as blocked because our current rate of failures in the various client test jobs (aka the segfaults) might end up making this super annoying if we have to keep retrying merges if it keeps failing CI during the merge queue step. |
|
Also just to clarify, this alone doesn't enable the merge queue, it still requires infra to actually hit the checkbox. But this prepares our CI manifests for it, so there's no harm in merging it now I suppose. |
|
CI is failing because of #1944, but I would like to land this now and we can try out the merge queue and disable it if it's problematic. |
We need to also trigger on the "merge_group" event for GitHub's merge queue to work. This is the same as <freedomofpress/securedrop-dev-docs#130>.
There was a problem hiding this comment.
LGTM, per previous conversations about heading towards merge queue and https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions
Status
Ready for review, needs discussion
Description
We need to also trigger on the "merge_group" event for GitHub's merge queue to work. This is the same as freedomofpress/securedrop-dev-docs#130.
Test Plan