Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding image to left pane and polish styling #520

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Aug 6, 2019

Resolves #518

Description

I could not find an issue for polishing the left pane and applying the "branding" image background. But here you'll find:

  • User icon character spacing correct width of 0.58
  • User profile widget formatted with the updated margins and padding
  • User dropdown menu button closer to the edge with updated margins and padding
  • branding background image that spans across the left pane and resizes correctly (little trick to stretch blue widget from the top for larger screen sizes)

@sssoleileraaa
Copy link
Contributor Author

Here's what it looks like now:

left-pane

@sssoleileraaa
Copy link
Contributor Author

Resolves #518

@eloquence eloquence changed the title Left pane Add branding image to left pane and polish styling Aug 7, 2019
@sssoleileraaa
Copy link
Contributor Author

For review, compare with zeplin brading bar which includes the user profile widget (user icon with the two letters, aka user badge, user name, and dropdown menu)

@ninavizz
Copy link
Member

ninavizz commented Aug 7, 2019

SVG art for this has been updated in the Content Inventory. :)

@sssoleileraaa
Copy link
Contributor Author

Note: The svg aspect ratio does not match the left pane dimensions when the client is maximum size, so I added a blue widget at the top of the left pane that can respond to window resizing by stretching.

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed:

  • User icon character spacing correct width of 0.58 (code check)
  • User profile widget formatted with the updated margins and padding
  • User dropdown menu button closer to the edge with updated margins and padding
  • branding background image that spans across the left pane and resizes correctly (little trick to stretch blue widget from the top for larger screen sizes) *confirmed branding pane resizes correctly and the branding graphic pins to the bottom when windows resized on larger screen.

One thing (and this might just be my QT noob status showing): would it be worthwhile defining constants for layout values (like the user icon character spacing) and referring to those rather than hard-coding the values? This is not a blocker for merge but it would make review (and rebranding) easier.

@sssoleileraaa sssoleileraaa merged commit 1c11677 into master Aug 12, 2019
@sssoleileraaa sssoleileraaa deleted the left-pane branch August 12, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[client styling] Apply branding bar background image
3 participants