Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focal] Fix reboot-flag cron syntax #5813

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[Focal] Fix reboot-flag cron syntax #5813

merged 1 commit into from
Feb 23, 2021

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Feb 23, 2021

Status

Ready for review

Description of Changes

Fixes #5812

Updates the cron syntax.

Since this is the only we managed, did not think it was worth adding chkcrontab against this file for every CI run

Testing

  • CI is passing
  • chkcrontab install_files/securedrop-config-focal/opt/securedrop/reboot-flag returns 0 [1]

Deployment

  • New and existing installs will be updated via the securedrop-config package (but these changes are focal-only so not yet in production)

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

[1] https://pypi.org/project/chkcrontab/

- No user was specified, so it tried to run as user "touch"
- Would run every minute of every 12 hours, which is overkill. It should now run at the 0th minute every 12 hours.
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chkcrontab is a cool tool, TIL. Checks out with local testing, good for merge.

@conorsch conorsch merged commit 9969993 into develop Feb 23, 2021
@emkll emkll deleted the 5812-reboot-cron branch February 23, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Focal] reboot flag daily cron syntax is incorrect
2 participants