Improving Developer Onboarding Documentation #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks a lot for the contribution, good documentation, examples etc. are what are needed the most for other devs right now. This looks good to me, if you want to go ahead I think we should add the instructions to add wasm32-unknown-unknown target to the book itself, since is missing from there too. We will probably change default behavior to mimic cargo, re. CARGO_TARGET_DIR, unsure about that... But for now is good to mention that. About the MacOS specific issues, definitively a bug, behavior should be the same across platforms, you are not the first that mentioned this either. Also would be good to know what issues does |
kernelkind
changed the title
iduartgomez
pushed a commit
that referenced
this pull request
Nov 6, 2023
* add comments to explain tutorials more * modify target directory command * add webassembly target command * change working app microblogging -> email. Has verbose readme
iduartgomez
pushed a commit
that referenced
this pull request
Nov 6, 2023
* add comments to explain tutorials more * modify target directory command * add webassembly target command * change working app microblogging -> email. Has verbose readme
iduartgomez
pushed a commit
that referenced
this pull request
Nov 6, 2023
* add comments to explain tutorials more * modify target directory command * add webassembly target command * change working app microblogging -> email. Has verbose readme
iduartgomez
pushed a commit
that referenced
this pull request
Nov 6, 2023
* add comments to explain tutorials more * modify target directory command * add webassembly target command * change working app microblogging -> email. Has verbose readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the instructions in the email app README and was able to get it running properly after running a few commands which weren't explicitly specified. I added the commands to the README and made a couple notes.
I could not get the email app example to work properly on MacOS. The code compiles and the app runs, but the account creation process is broken. Upon pressing the "Create" button, the app takes the user back to the "Create new identity" page without the created account displayed.
If this is user error, please let me know. Otherwise, I can create an issue so it can be fixed.