-
-
Notifications
You must be signed in to change notification settings - Fork 158
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move development dependencies from gemspec to Gemfile
Gemspec should not contain `RUBY_VERSION` as a condition to switch dependencies, because it is meaningless. Please see the following for details: - rubocop/rubocop#7137 - rubocop/ruby-style-guide#763 In addition, Bundler no longer uses `add_development_dependency` when genererating new gems. - rubygems/bundler#7222 For these reason, this PR moves development dependencies from gemspec to Gemfile.
- Loading branch information
1 parent
65bc626
commit dd127f7
Showing
4 changed files
with
34 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,34 @@ | ||
source 'https://rubygems.org' | ||
|
||
gemspec | ||
|
||
# rubocop:disable Bundler/DuplicatedGem | ||
if RUBY_VERSION < '1.9.3' | ||
gem 'rake', '~> 10.0' | ||
elsif RUBY_VERSION < '2' | ||
gem 'rake', '~> 12.2.1' | ||
elsif RUBY_VERSION < '2.2' | ||
gem 'rake', '~> 12.3.3' | ||
else | ||
gem 'rake' | ||
end | ||
# rubocop:enable Bundler/DuplicatedGem | ||
|
||
gem 'introspection', '~> 0.0.1' | ||
|
||
# Avoid breaking change in psych v4 (https://bugs.ruby-lang.org/issues/17866) | ||
if RUBY_VERSION >= '3.1.0' | ||
gem 'psych', '< 4' | ||
end | ||
|
||
if RUBY_VERSION >= '2.2.0' | ||
# No test libraries in standard library | ||
gem 'minitest' | ||
end | ||
if RUBY_VERSION >= '2.2.0' | ||
gem 'rubocop', '<= 0.58.2' | ||
end | ||
if ENV['MOCHA_GENERATE_DOCS'] | ||
gem 'redcarpet' | ||
gem 'yard' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,5 +3,6 @@ source 'https://rubygems.org' | |
gemspec :path=>"../" | ||
|
||
group :development do | ||
gem "rake" | ||
gem "minitest" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters