Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipq40xx-chromium: add support for Google WiFi (Gale) #2885

Closed

Conversation

AiyionPrime
Copy link
Member

@AiyionPrime AiyionPrime commented May 3, 2023

as well as the target itself

Tested-by: Andrijan Möcker [email protected]

My goal is to have this device in the current gluon master, hence in the Gluon-Release we do before/when OpenWrt 23.xx lands.

This PR obviously can not be merged as is.
I started an effort to backport the ten included patches in OpenWrt, which won't be as easy as I assumed. Though the suggested changes are as isolated as they can be and do not affect other devices let alone targets, adding them in OpenWrt would cost several hours and time of different OpenWrt maintainers.

Adding a new target in OpenWrt's stable is a thing that can be done, but is currently troublesome, due to some signatures that became invalid on OpenWrts side.
Furthermore different maintainers would be involved, whose time would be better spent in upcoming releases than in troublesome backports.

Maintaining the included ten commits downstream should be trivial, as they mostly affect the chromium-subtarget introduced in them which does not exist in OpenWrt's stable yet.
If we'd agree to have them downstream, I'd volunteer to maintain them.

Maybe @NeoRaider has a favored approach, @blocktrron was against doing this upstream, as long as he's involved, if not at all.

I'd be fine with either solution, but would like to see this device in gluon, as it has a decent dual-band ac performance and looks nice.

note: once @ctandi commences testing the patches, I'll squash this PR accordingly.

@github-actions github-actions bot added the 3. topic: hardware Topic: Hardware Support label May 3, 2023
@AiyionPrime AiyionPrime added 2. status: blocked Marked as blocked because it's waiting on something 4. has: upstream-patches This changeset backports upstream patches 2. status: rfc request for comments 5. needs: testing Testing of the changes is necessary labels May 3, 2023
@rotanid
Copy link
Member

rotanid commented May 6, 2023

we discussed on IRC that this does not work with the current rules we gave us.
the device is not supported yet in openwrt-22.03 and maybe never will be and the device would also be marked as BROKEN, which excludes it from the upstream-backport-exception...

@AiyionPrime AiyionPrime added 2. status: wontfix The issue raised is out of scope for this project and removed 2. status: rfc request for comments 2. status: blocked Marked as blocked because it's waiting on something 5. needs: testing Testing of the changes is necessary labels May 6, 2023
@AiyionPrime AiyionPrime closed this May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: wontfix The issue raised is out of scope for this project 3. topic: hardware Topic: Hardware Support 4. has: upstream-patches This changeset backports upstream patches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants