-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patches: add support for Zyxel NWA1121 #39
base: master
Are you sure you want to change the base?
Conversation
Oliver gave me some of these devices. This patch adds support for them.
i tried building it on my local build machine. first try i got an error (without verbose so i did not see the error), second try the build process waited for me to answear if he should build an image for this device and i answered with y and it continued: |
@Dark4MD Thank you very much. Unfortunately I don't have access to your Google drive. Please use e.g. https://transfer.sh instead. |
https://transfer.sh/m9UUy/gluon-ffh-vH0.dev.20190622-zyxel-nwa1121-sysupgrade.bin |
Thank you very much. Unfortunately the patch writer did not know about partitioning in OpenWrt. Thus I need to change the layout later. |
Codefetch may unblock this, if he changed the layout. |
Someone is working on support for this device an even for the ATH79 Target :D Oh, just saw that he is one of us XD Explains a lot |
Looks like @s-2 's upstream contribution right now just needs an updated commit message? |
@CodeFetch was the request to merge this into master intentional? Shouldn't we start with nightly? |
@AiyionPrime No, this is just kept open for reference. |
Is there anything that should be improved regarding the commit messages of #4037? I had tested NWA-1121-NI with gluon months ago, meanwhile the device vanished from the map since I had to flash it back to OpenWrt for testing changes made to the PR. |
I hope a merging in OpenWrt... |
@s-2 @CodeFetch openwrt/openwrt@251ecfe was merged 16 days ago. Time to rebase this accordingly and reduce it to a gluon-only patch. |
@CodeFetch I suppose a 'backport' into this PR would be pretty easy given that 22.03 isn't that far from master yet. But @s-2 and me came to the conclusion that we won't do that for this device. Do you intend to? |
Current state of gluon patch is here: https://github.com/s-2/gluon/tree/zyxel_nwa11xx |
@s-2: I hope! |
This needs a rebase, if this should ever happen. |
Oliver gave me some of these devices.
This patch adds support for them.
@Dark4MD I'd really like to have an image for them. I haven't tested it. Let's see what Jenkins says...