Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Innhold i tabeller må toppjusteres som default #2434

Closed
wkillerud opened this issue Nov 2, 2021 · 2 comments · Fixed by #2485
Closed

Innhold i tabeller må toppjusteres som default #2434

wkillerud opened this issue Nov 2, 2021 · 2 comments · Fixed by #2485
Assignees
@wkillerud
Labels
✨ Forslag Forslag til nye funksjoner og endringer

Comments

@wkillerud
Copy link
Contributor

Diskusjon

Screenshot 2021-11-01 at 12 36 02
Screenshot 2021-11-01 at 12 35 04

her er 2 eksempler @onordbo

Originally posted by @karimarkhus in #2333 (reply in thread)

Forslag til løsning

Endre default vertical-align til toppjustering og ha modifiers for de to andre variantene (sentrert og bunn).

Dokumenter med sentrerte knapper der de finnes.
@wkillerud wkillerud added the ✨ Forslag Forslag til nye funksjoner og endringer label Nov 2, 2021
@wkillerud
Copy link
Contributor Author

@all-contributors please add @karimarkhus for design

@allcontributors allcontributors bot mentioned this issue Nov 10, 2021
Merged
@allcontributors
Copy link
Contributor

@wkillerud

I've put up a pull request to add @karimarkhus! 🎉

@wkillerud wkillerud self-assigned this Nov 10, 2021
wkillerud added a commit that referenced this issue Nov 10, 2021
@wkillerud
fix: endre standard vertical-align i henhold til design
d732aa1 
affects: @fremtind/jkl-table-react, @fremtind/jkl-table

`verticalAlign="top"` er nå en no-op og kan fjernes

ISSUES CLOSED: #2434
wkillerud added a commit that referenced this issue Nov 10, 2021
@wkillerud
fix: endre standard vertical-align i henhold til design
3a58303 
affects: @fremtind/jkl-table-react, @fremtind/jkl-table

`verticalAlign="top"` er nå en no-op og kan fjernes

ISSUES CLOSED: #2434
@wkillerud wkillerud mentioned this issue Nov 10, 2021
Merged
5 tasks
wkillerud added a commit that referenced this issue Nov 11, 2021
@wkillerud
fix: endre standard vertical-align i henhold til design
a545a58 
affects: @fremtind/jkl-table-react, @fremtind/jkl-table

`verticalAlign="top"` er nå en no-op og kan fjernes

ISSUES CLOSED: #2434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkillerud wkillerud

Labels
✨ Forslag Forslag til nye funksjoner og endringer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: toppjuster tabellinnhold som standard fremtind/jokul
1 participant
@wkillerud