Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browserslist-config-jkl installeres ikke #862

Closed
gbrownlee opened this issue Mar 24, 2020 · 0 comments · Fixed by #864
Closed

browserslist-config-jkl installeres ikke #862

gbrownlee opened this issue Mar 24, 2020 · 0 comments · Fixed by #864
Assignees
@gbrownlee

Comments

@gbrownlee
Copy link
Contributor

Describe the bug
browserslist-config-jkl installeres ikke fordi den er satt som en devDependency. Dette gjør at man manuelt må installere denne pakken selv om den er nødvendig for å bruke bl.a. jkl-core. Man får da naturligvis en "Cannot find module"-feilmelding.

To Reproduce

  1. Installer jkl-core i f.eks. et nytt create-react-app-prosjekt
  2. Start serveren.

Expected behavior
Forventes å kunne fungere uten å måtte installere ytterligere pakker med mindre man faktisk skal utvikle pakken. Som dokumentert hos npm
@gbrownlee gbrownlee self-assigned this Mar 24, 2020
gbrownlee pushed a commit that referenced this issue Mar 24, 2020
fix(core): change browserslist devDependency to dependency
bb9c088 
affects: @fremtind/jkl-core

ISSUES CLOSED: #862
@gbrownlee gbrownlee mentioned this issue Mar 24, 2020
Closed
4 tasks
piofinn added a commit that referenced this issue Mar 25, 2020
@piofinn
fix: move browserslist declaration to root package.json
51c790e 
affects: @fremtind/jkl-accordion-react, @fremtind/jkl-accordion, @fremtind/jkl-button-react,
@fremtind/jkl-button, @fremtind/jkl-card-react, @fremtind/jkl-card, @fremtind/jkl-checkbox-react,
@fremtind/jkl-checkbox, @fremtind/jkl-core, @fremtind/jkl-datepicker-react,
@fremtind/jkl-datepicker, @fremtind/jkl-divider-line-react, @fremtind/jkl-divider-line,
@fremtind/jkl-field-group-react, @fremtind/jkl-field-group, @fremtind/jkl-hamburger-react,
@fremtind/jkl-hamburger, @fremtind/jkl-list-react, @fremtind/jkl-list, @fremtind/jkl-loader-react,
@fremtind/jkl-loader, @fremtind/jkl-logo-react, @fremtind/jkl-logo, @fremtind/jkl-message-box-react,
@fremtind/jkl-message-box, @fremtind/jkl-portal-components, @fremtind/jkl-progress-bar-react,
@fremtind/jkl-progress-bar, @fremtind/jkl-radio-button-react, @fremtind/jkl-radio-button,
@fremtind/jkl-react-hooks, @fremtind/jkl-select-react, @fremtind/jkl-select,
@fremtind/jkl-table-react, @fremtind/jkl-table, @fremtind/jkl-text-input-react,
@fremtind/jkl-text-input, @fremtind/jkl-toggle-switch-react, @fremtind/jkl-toggle-switch,
@fremtind/jkl-typography-react, @fremtind/jkl-webfonts

Move browserslist declaration to root package.json and remove the browserslist-config-jkl package as
a dependency from the other packages. This solves a bug where our packages would cause issues with
PostCSS when used in other projects.

ISSUES CLOSED: #862
@piofinn piofinn mentioned this issue Mar 25, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbrownlee gbrownlee

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@gbrownlee