-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): flatten structure of core package #140
Conversation
affects: @fremtind/jkl-accordion, @fremtind/jkl-bullet-list, @fremtind/jkl-button, @fremtind/jkl-card, @fremtind/jkl-checkbox, @fremtind/jkl-core, @fremtind/jkl-divider-line, @fremtind/jkl-dropdown, @fremtind/jkl-footer, @fremtind/jkl-grid, @fremtind/jkl-header, @fremtind/jkl-logo, @fremtind/jkl-radio-button, @fremtind/jkl-text-input also change all imports accordingly in other packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an improvement. We should clear the PRs before taking on this, as this is a breaking change for the entire project.
Also checkout the _index.scss file instead of _variables.scss and _mixin.scss
Also cpx, ncp depdendencies can be deleted |
Not possible yet in node-sass as of yet (new feature in LibSass from May)
Yep. All existing packages have their imports updated here, but we should consolidate all the incoming changes as well. |
affects: @fremtind/jkl-core
affects: @fremtind/portal
affects: @fremtind/jkl-accordion, @fremtind/jkl-bullet-list, @fremtind/jkl-button,
@fremtind/jkl-card, @fremtind/jkl-checkbox, @fremtind/jkl-core, @fremtind/jkl-divider-line,
@fremtind/jkl-dropdown, @fremtind/jkl-footer, @fremtind/jkl-grid, @fremtind/jkl-header,
@fremtind/jkl-logo, @fremtind/jkl-radio-button, @fremtind/jkl-text-input
📥 Proposed changes
Flatten structure of
core
package as proposed in issue #139☑️ Submission checklist
yarn build
works locally with my changes💬 Further comments
Fixes #139