Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: small improvements to forced colors mode #4400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: small improvements to forced colors mode #4400

wants to merge 1 commit into from
+44 −24

Conversation

ivarni
Copy link
Contributor

@ivarni ivarni commented Jan 2, 2025 •
edited
Loading

🎯 Sjekkliste

  • pnpm build og pnpm ci:test gir ingen feil

CLOSES #4347

@fremtind-bot
Copy link
Collaborator

fremtind-bot commented Jan 2, 2025 •
edited
Loading

✅ Forhåndsvisning: https://jokul.fremtind.no/preview/4347-forced-colors/
🔍 Commit: f7d98ce

Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes.

fremtind-bot added a commit that referenced this pull request Jan 2, 2025
@fremtind-bot
docs: preview #4400
ac41d71
@ivarni ivarni marked this pull request as ready for review January 2, 2025 09:09
@kristianulv23 kristianulv23 self-requested a review January 2, 2025 13:56
kristianulv23
kristianulv23 requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@kristianulv23 kristianulv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handling-knappen får en svart fokus-outline i dark mode ved tastaturnavigasjon. Det ser ellers betydelig bedre ut.

@ivarni ivarni force-pushed the 4347-forced-colors branch from e6ab964 to ee0e4ea Compare January 3, 2025 07:55
@ivarni ivarni requested a review from kristianulv23 January 3, 2025 07:55
fremtind-bot added a commit that referenced this pull request Jan 3, 2025
@fremtind-bot
docs: preview #4400
b1f59c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristianulv23 kristianulv23 kristianulv23 approved these changes

@piofinn piofinn Awaiting requested review from piofinn

@zenabii zenabii Awaiting requested review from zenabii

@olejorgenbakken olejorgenbakken Awaiting requested review from olejorgenbakken

Assignees
No one assigned
Labels
None yet
Projects
Jøkul-teamet
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feil: TextInput m/handling ser litt jalla ut i forced-colors mode
3 participants
@ivarni @fremtind-bot @kristianulv23