Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ci-base-image is not behaving as expected #1727

Closed
2 tasks
mattheworris opened this issue Oct 20, 2023 · 0 comments · Fixed by #1728
Closed
2 tasks

bug: ci-base-image is not behaving as expected #1727

mattheworris opened this issue Oct 20, 2023 · 0 comments · Fixed by #1728
Assignees
@mattheworris

Comments

@mattheworris
Copy link
Collaborator

The goal of this issue is to figure out why the ci-base-image does not seem to have both the stable and nightly rust toolchains installed when running in CI.

Acceptance Criteria:

  • Determine the status of the nightly toolchain install in the ci-base-image
  • Remove redundant rust install commands or remove nightly install from ci-base-image
@mattheworris mattheworris self-assigned this Oct 20, 2023
@mattheworris mattheworris mentioned this issue Oct 24, 2023
Merged
mattheworris pushed a commit that referenced this issue Oct 24, 2023
# Goal
36e1b9c 
This PR aims to remove the `rustup install toolchain nightly` commands from the individual
GitHub jobs that use the `ci-base-image` that previously did not have the `nightly` toolchain.

Closes #1727

 # Discussion
The changes in the previous PR (#1700) to add the `nightly` toolchain to `ci-base-image` were
not published to DockerHub until the `merge-pr.yml` workflow actions were successfully run.
Therefore the `nightly` toolchain was not available for CI to use in `ci-base-image`.

In that PR, the `nightly` toolchain was installed in the individual jobs where it was needed to pass CI.

Now that the PR has been merged, `ci-base-image` has been updated with both the `stable`
and `nightly` toolchains and the redundant `rustup install` commands can be removed from `verify-pr-commit.yml`.
mattheworris added a commit that referenced this issue Oct 25, 2023
@mattheworris
Remove redundant rustup install commands from github workflows after …
3c9488a 
…ci-base-image update (#1728)

# Goal
This PR aims to remove the `rustup install toolchain nightly` commands
from the individual GitHub jobs that use the `ci-base-image` that
previously did not have the `nightly` toolchain.

Closes #1727

# Discussion
The changes in the previous PR (#1700) to add the `nightly` toolchain to
`ci-base-image` were not published to DockerHub until the `merge-pr.yml`
workflow actions were successfully run. Therefore the `nightly`
toolchain was not available for CI to use in `ci-base-image`.

In that PR, the `nightly` toolchain was installed in the individual jobs
where it was needed to pass CI.

Now that the PR has been merged, `ci-base-image` has been updated with
both the `stable` and `nightly` toolchains and the redundant `rustup
install` commands can be removed from `verify-pr-commit.yml`.

Co-authored-by: Matthew Orris <--help>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattheworris mattheworris

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mattheworris