Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository rulesets and a docs section to configure the GitHub repository #192

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Dec 7, 2023

This is based on the instructions in the Wiki.

Only a few adjustments are made to fix a few out of date data and to make it fit better to the current existing documentation.

The instructions to configure the RELEASE_NOTES.md update check is removed because now it's spread in the rest of the configuration (the adding of the label is moved to the Labels section, and the check is included in the rulesets now).

After this commit is merged they will be superseded by the instructions in the docs.

To build the links to the rulesets, we add a new mkdocs macro variable to get the current default branch, which is only used when there is no GitHub information about the current version (mainly when running locally).

Rulesets simplify the branch protection configuration as you can import
and export them. To make users life easier while configuring the
repository we provide a new set with the recommended configuration.

For more info see:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/about-rulesets

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax self-assigned this Dec 7, 2023
@llucax llucax added part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:enhancement New feature or enhancement visitble to users labels Dec 7, 2023
@llucax llucax added this to the v0.8.0 milestone Dec 7, 2023
@github-actions github-actions bot removed part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Dec 7, 2023
This is only to make them a bit more friendly to the eyes when looking
at the text version.

Signed-off-by: Leandro Lucarella <[email protected]>
This is based on the instructions in the Wiki:
https://github.com/frequenz-floss/frequenz-repo-config-python/wiki/Configuring-a-new-GitHub-repository

Only a few adjustments are made to fix a few out of date data and to
make it fit better to the current existing documentation.

The instructions to configure the `RELEASE_NOTES.md` update check is
removed because now it's spread in the rest of the configuration (the
adding of the label is moved to the Labels section, and the check is
included in the rulesets now).

After this commit is merged they will be superseded by the instructions
in the docs.

To build the links to the rulesets, we add a new mkdocs macro variable
to get the current default branch, which is only used when there is no
GitHub information about the current version (mainly when running
locally).

Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax marked this pull request as ready for review December 7, 2023 11:10
@llucax llucax requested a review from a team as a code owner December 7, 2023 11:10
@@ -100,7 +100,7 @@ This will only install your package in *editable* mode and the minimum
dependencies required to run `nox`. It will then run all `nox` default
sessions, which include running linters and tests.

!!! note
!!! Tip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!! Note

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was changed on purpose, is more a tip than a note, forgot to mention it in the commit

@llucax llucax added this pull request to the merge queue Dec 7, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit 00016c4 Dec 7, 2023
14 checks passed
@llucax llucax deleted the rulesets branch December 7, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants