Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for v0.8.0 release #204

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Prepare for v0.8.0 release #204

merged 1 commit into from
Dec 20, 2023

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Dec 18, 2023

Bump the version in the cookiecutter template and update the release notes.

@llucax llucax requested a review from a team as a code owner December 18, 2023 12:21
@llucax llucax self-assigned this Dec 18, 2023
@llucax llucax added this to the v0.8.0 milestone Dec 18, 2023
@github-actions github-actions bot added the part:cookiecutter Affects the generation of projects using cookiecutter label Dec 18, 2023
@llucax
Copy link
Contributor Author

llucax commented Dec 18, 2023

This one is to merge last, and will probably need to fix some conflicts, so setting as draft. But the contents can be reviewed now.

@llucax llucax marked this pull request as draft December 18, 2023 12:23
@llucax llucax marked this pull request as ready for review December 20, 2023 13:32
@llucax llucax enabled auto-merge December 20, 2023 13:32
@llucax
Copy link
Contributor Author

llucax commented Dec 20, 2023

Rebased and set as ready for review.

@llucax llucax disabled auto-merge December 20, 2023 13:33
@llucax
Copy link
Contributor Author

llucax commented Dec 20, 2023

Sorry, I forgot to add upgrading instructions, will update soon again.

@llucax
Copy link
Contributor Author

llucax commented Dec 20, 2023

Done!

@llucax llucax enabled auto-merge December 20, 2023 13:49
daniel-zullo-frequenz
daniel-zullo-frequenz previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 optional suggestions, LGTM

@llucax llucax added this pull request to the merge queue Dec 20, 2023
@daniel-zullo-frequenz daniel-zullo-frequenz removed this pull request from the merge queue due to a manual request Dec 20, 2023
@daniel-zullo-frequenz
Copy link
Contributor

Sorry, I removed it from the merging queue in case you'd like to address the optional suggestions

@llucax
Prepare for v0.8.0 release
e602cac 
Bump the version in the cookiecutter template and update the release
notes.

Signed-off-by: Leandro Lucarella <[email protected]>
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests and removed part:cookiecutter Affects the generation of projects using cookiecutter labels Dec 20, 2023
@llucax
Copy link
Contributor Author

llucax commented Dec 20, 2023

Updated with the suggestions and also updated the tests (they will probably still fail because the version in the dependencies doesn't exist yet, this can be only fixed when we split this repo).

@llucax llucax enabled auto-merge December 20, 2023 14:26
@llucax llucax added this pull request to the merge queue Dec 20, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit 711ac38 Dec 20, 2023
14 checks passed
@llucax llucax deleted the fix-version branch December 20, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-zullo-frequenz daniel-zullo-frequenz daniel-zullo-frequenz approved these changes

Assignees

@llucax llucax

Labels
part:tests Affects the unit, integration and performance (benchmarks) tests
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@llucax @daniel-zullo-frequenz