Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copyright year fakable in golden tests #212

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Jan 2, 2024

We need this to avoid having golden tests fail when the year changes.

Happy new year, everyone!

@llucax llucax requested a review from a team as a code owner January 2, 2024 11:03
@github-actions github-actions bot added the part:tests Affects the unit, integration and performance (benchmarks) tests label Jan 2, 2024
We need this to avoid having golden tests fail when the year changes.

Happy new year, everyone!

Signed-off-by: Leandro Lucarella <[email protected]>
@github-actions github-actions bot added the part:cookiecutter Affects the generation of projects using cookiecutter label Jan 2, 2024
@llucax llucax changed the title Update golden tests to use 2024 as copyright year Make copyright year fakable in golden tests Jan 2, 2024
@llucax llucax self-assigned this Jan 2, 2024
@llucax llucax added the type:bug Something isn't working label Jan 2, 2024
@llucax llucax added this to the v0.9.0 milestone Jan 2, 2024
@llucax llucax added cmd:skip-release-notes It is not necessary to update release notes for this PR type:tech-debt Improves the project without visible changes for users and removed type:tech-debt Improves the project without visible changes for users labels Jan 2, 2024
@llucax llucax enabled auto-merge January 2, 2024 12:19
auto-merge was automatically disabled January 2, 2024 12:21

Merge queue setting changed

@llucax llucax enabled auto-merge January 2, 2024 12:52
@leandro-lucarella-frequenz
Copy link
Contributor

I will force-merge because tests are broken without this, but a post-merge review would be appreciated!

@leandro-lucarella-frequenz leandro-lucarella-frequenz merged commit c87225e into frequenz-floss:v0.x.x Jan 2, 2024
17 of 19 checks passed
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the world fakable exists. Anyway I had only an optional comment. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd:skip-release-notes It is not necessary to update release notes for this PR part:cookiecutter Affects the generation of projects using cookiecutter part:tests Affects the unit, integration and performance (benchmarks) tests type:bug Something isn't working type:tech-debt Improves the project without visible changes for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants