ci: Support using git for dependencies in test-installation
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:template
llucax
changed the title
test-installation
llucax
added
part:ci
|
Updating the tests should be just: Ideally this repo should get the fix. I plan to dedicate some time to repo-config in a not so distant future, if you didn't take care of it until then I can take it over. |
llucax
requested changes
Feb 8, 2024
llucax
force-pushed
the
git-dep-inst-test
branch
from
16e112d to
4ed2378
Compare
llucax
previously approved these changes
Feb 19, 2024
|
OK, I took over this one and updated with the missing stuff. But now it needs an approval from someone else :) |
|
Yeah, I can't approve this, being the author and all. |
cwasicki
approved these changes
Feb 19, 2024
When git dependencies are used in the `pyproject.toml` file, the `test-installation` CI job fails because git is not installed, so the dependencies can't be retrieved. We install git in the container to fix this. Signed-off-by: Mathias L. Baumann <[email protected]> Co-authored-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
git-dep-inst-test
branch
from
4ed2378 to
a30ce51
Compare
leandro-lucarella-frequenz
approved these changes
Feb 20, 2024
shsms
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the CI test that fails when dependencies in pyproject.toml contain git urls.
I didn't have time to update the tests, feel free to take over.