Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing instruction to update dependencies #223

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Feb 8, 2024

When updating the version of frequenz-api-common dependency we also need to update the link to the inventory for cross-references in mkdocs.yml to point to the new version.

Using double quotes can be problematic when backslashes are used in the
string.

Signed-off-by: Leandro Lucarella <[email protected]>
The release notes were missing a `-i` in the `sed` command suggested to
update the `pylint` ignore rules.

Signed-off-by: Leandro Lucarella <[email protected]>
When updating the version of `frequenz-api-common` dependency we also
need to update the link to the inventory for cross-references in
`mkdocs.yml` to point to the new version.

Signed-off-by: Leandro Lucarella <[email protected]>
Include a command-line to fix the files inplace without having to
re-generate the files from the templates.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax requested a review from a team as a code owner February 8, 2024 11:36
@llucax llucax self-assigned this Feb 8, 2024
@llucax llucax added this to the v0.9.0 milestone Feb 8, 2024
@github-actions github-actions bot added the part:template Affects the cookiecutter template files label Feb 8, 2024
@llucax llucax added part:docs Affects the documentation type:enhancement New feature or enhancement visitble to users labels Feb 8, 2024
@llucax llucax enabled auto-merge February 19, 2024 15:11
@llucax
Copy link
Contributor Author

llucax commented Feb 19, 2024

Enabled auto-merge.

@llucax llucax added this pull request to the merge queue Feb 19, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit a09a130 Feb 19, 2024
16 checks passed
@llucax llucax deleted the api-updates-contrib branch February 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:docs Affects the documentation part:template Affects the cookiecutter template files type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants