Fetch submodules when doing cross-arch tests #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:template
Closed
llucax
added
type:bug
|
Enabled auto-merge. |
matthias-wende-frequenz
previously approved these changes
Feb 19, 2024
We need to do that because if the project has submodules, they need to be available when running the tests in the container too. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
api-fetch-submodules
branch
from
ed6cc5f to
eb09fb4
Compare
|
Rebased to resolve some conflicts, needs a new approval @matthias-wende-frequenz |
leandro-lucarella-frequenz
previously approved these changes
Feb 20, 2024
|
Self-approving 😬 |
|
It doesn't work, either I have to force merge or wait for another approval. |
leandro-lucarella-frequenz
merged commit 0916f1b
into
frequenz-floss:v0.x.x
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do that because if the project has submodules, they need to be available when running the tests in the container too.